Skip to content

move fast reject into inner #142355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 15, 2025
Merged

move fast reject into inner #142355

merged 1 commit into from
Jun 15, 2025

Conversation

lcnr
Copy link
Contributor

@lcnr lcnr commented Jun 11, 2025

to also fast reject inside of the folder

r? @BoxyUwU

@lcnr
move fast reject into inner
a48c085 
to also fast reject inside of the folder
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 11, 2025
@lcnr
Copy link
Contributor Author

lcnr commented Jun 11, 2025

@bors2 try @rust-timer queue

@rust-timer

This comment has been minimized.

Sign in to view
@rust-bors
Copy link

rust-bors bot commented Jun 11, 2025

⌛ Trying commit a48c085 with merge 15d9005…

To cancel the try build, run the command @bors2 try cancel.

rust-bors bot added a commit that referenced this pull request Jun 11, 2025
@rust-bors
Auto merge of #142355 - lcnr:fast_reject-reject, r=<try>
15d9005 
move fast reject into inner

to also fast reject inside of the folder

r? `@BoxyUwU`
@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jun 11, 2025
@lcnr lcnr mentioned this pull request Jun 11, 2025
Merged
@rust-bors
Copy link

rust-bors bot commented Jun 11, 2025

☀️ Try build successful (CI)
Build commit: 15d9005 (15d9005af7fe2850d61be59a912b1931dc1eb5f2)

@rust-timer

This comment has been minimized.

Sign in to view
compiler-errors
compiler-errors approved these changes Jun 11, 2025
View reviewed changes
Copy link
Member

@compiler-errors compiler-errors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me if perf is good

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (15d9005): comparison URL.

Overall result: ✅ improvements - no action needed

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -0.3% [-0.5%, -0.1%] 20
Improvements ✅
(secondary)		 -0.6% [-0.6%, -0.6%] 1
All ❌✅ (primary) -0.3% [-0.5%, -0.1%] 20

Max RSS (memory usage)

Results (primary 2.4%, secondary -3.9%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 2.4% [2.4%, 2.4%] 1
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -3.9% [-3.9%, -3.9%] 1
All ❌✅ (primary) 2.4% [2.4%, 2.4%] 1

Cycles

Results (secondary 2.6%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 2.6% [2.6%, 2.6%] 1
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 754.155s -> 754.369s (0.03%)
Artifact size: 372.17 MiB -> 372.08 MiB (-0.02%)

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jun 12, 2025
@BoxyUwU
Copy link
Member

BoxyUwU commented Jun 12, 2025

@bors r+ rollup=never

@bors
Copy link
Collaborator

bors commented Jun 12, 2025

📌 Commit a48c085 has been approved by BoxyUwU

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 12, 2025
@fmease
Copy link
Member

fmease commented Jun 14, 2025

precedence over next rollup @bors p=5

@bors
Copy link
Collaborator

bors commented Jun 15, 2025

⌛ Testing commit a48c085 with merge 32b5152...

@bors
Copy link
Collaborator

bors commented Jun 15, 2025

☀️ Test successful - checks-actions
Approved by: BoxyUwU
Pushing 32b5152 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jun 15, 2025
@bors bors merged commit 32b5152 into rust-lang:master Jun 15, 2025
11 checks passed
@rustbot rustbot added this to the 1.89.0 milestone Jun 15, 2025
@github-actions GitHub Actions
Copy link
Contributor

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 38c41d0 (parent) -> 32b5152 (this PR)

Test differences

No test diffs found

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 32b51523f81a5f916c4bb3fee5a749721f19e01d --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. x86_64-apple-2: 3163.2s -> 6721.6s (112.5%)
  2. dist-apple-various: 5533.6s -> 7657.7s (38.4%)
  3. x86_64-apple-1: 5802.8s -> 7820.0s (34.8%)
  4. x86_64-rust-for-linux: 2496.6s -> 3055.3s (22.4%)
  5. x86_64-gnu-stable: 6918.9s -> 8299.9s (20.0%)
  6. dist-aarch64-msvc: 8067.6s -> 9489.3s (17.6%)
  7. dist-aarch64-apple: 5337.9s -> 6083.7s (14.0%)
  8. aarch64-apple: 4694.6s -> 5325.5s (13.4%)
  9. mingw-check-1: 1634.0s -> 1850.7s (13.3%)
  10. i686-gnu-nopt-1: 7141.2s -> 8021.9s (12.3%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (32b5152): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -0.4% [-0.5%, -0.1%] 15
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) -0.4% [-0.5%, -0.1%] 15

Max RSS (memory usage)

Results (secondary -4.8%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -4.8% [-4.8%, -4.8%] 1
All ❌✅ (primary) - - 0

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 757.13s -> 755.461s (-0.22%)
Artifact size: 372.17 MiB -> 372.12 MiB (-0.01%)

@lcnr lcnr deleted the fast_reject-reject branch June 15, 2025 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compiler-errors compiler-errors compiler-errors approved these changes

Assignees

@BoxyUwU BoxyUwU

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.89.0
Development

Successfully merging this pull request may close these issues.
7 participants
@lcnr @rust-timer @BoxyUwU @bors @fmease @compiler-errors @rustbot